Deny creating tables with column comment if unsupported #12574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
added
the
no-release-notes
i think this should be in release notes. |
findepi
approved these changes
May 27, 2022
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryMetadata.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/test-create-table-with-column-comment
branch
from
83ea6de to
2f12b2a
Compare
ebyhr
removed
the
no-release-notes
Closed
ssheikin
reviewed
Jun 1, 2022
| @@ -549,6 +549,9 @@ protected String createTableSql(RemoteTableName remoteTableName, List<String> co | |||
|
|
|||
| protected String getColumnDefinitionSql(ConnectorSession session, ColumnMetadata column, String columnName) | |||
| { | |||
| if (column.getComment() != null) { | |||
| throw new TrinoException(NOT_SUPPORTED, "This connector does not support creating tables with column comment"); | |||
There was a problem hiding this comment.
@ebyhr getColumnDefinitionSql method is used for both 'create table' and 'add column' flows
So the exception message during 'add column' flow is not correct.
Could you please help to tackle that situation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deny creating tables with column comment if unsupported
Documentation
(x) No documentation is needed.
Release notes
(x) Release notes entries required with the following suggested text: